fix(language-service): be resilient to invalidate ordering

Fixes angular#15466
chuckjaz · Mar 24, 2017 · f7f313d · f7f313d
1 parent 92084f2
commit f7f313d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/language-service/src/typescript_host.ts b/packages/language-service/src/typescript_host.ts
@@ -492,7 +492,7 @@ export class TypeScriptServiceHost implements LanguageServiceHost {
             const type = this.checker.getTypeAtLocation(target);
             if (type) {
               const staticSymbol =
-                  this._reflector.getStaticSymbol(sourceFile.fileName, classDeclaration.name.text);
+                  this.reflector.getStaticSymbol(sourceFile.fileName, classDeclaration.name.text);
               try {
                 if (this.resolver.isDirective(staticSymbol as any)) {
                   const {metadata} =

diff --git a/packages/language-service/test/diagnostics_spec.ts b/packages/language-service/test/diagnostics_spec.ts
@@ -52,6 +52,15 @@ describe('diagnostics', () => {
       includeDiagnostic(diagnostics(template), message, at, len);
     }
 
+    describe('regression', () => {
+      it('should be able to return diagnostics if reflector gets invalidated', () => {
+        const fileName = '/app/main.ts';
+        ngService.getDiagnostics(fileName);
+        (ngHost as any)._reflector = null;
+        ngService.getDiagnostics(fileName);
+      });
+    });
+
     describe('with $event', () => {
       it('should accept an event',
          () => { accept('<div (click)="myClick($event)">Click me!</div>'); });