-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polymer-quill doesn't work in Shadow DOM #10
Comments
Currently Quilljs does not work with Shadow DOM. Will give it another try with Shadow DOM when porting to Polymer 2.0. See issue for more information: slab/quill#904 |
I have a working hack. I had to modify both quill and the polymer-quill to get it working. As mentioned this is a hack and definitely not suitable for production use. As I have very little free time I could not do a pull request. I am attaching the files which I modified. If you find the hack suitable you can use it to modify the code and get it working in shadowDom. To summarize the changes are as follows Quill.js
Polymer-quill
I have used it in my project and it is getting tested along with other things. Please do a diff to find out all the changes. Review and only then include the changes appropriately. This can be modified to work both with shady DOM and shadow DOM. I just needed only shadow DOM for my project. Hope this is of some use. |
Thanks. Hope it gets into the main code base.
I had only did it as a hack - so you may have to improve the code before
you put it in.
Regards,
S.Satyanath
…On 30-06-2017 09:28, Alexis Hernandez wrote:
@satyanath <https://github.com/satyanath>
Nice mod! It's working!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFQiA-RCEpQyXrEyrzD9Ddzkr5JZVNNXks5sJHJ8gaJpZM4L9ZMA>.
|
Hi Asha-N,
IE and Firefox do not support Shadow DOM. Hence you cannot use this hack
there. You will have to modify to code to not apply the hack when you
detect IE and Firefox.
Hope this helps.
Regards,
S.Satyanath
…On 13-07-2017 17:29, Asha-N wrote:
satyanath sir,
This hack works only for chrome. How to make it work for IE and firefox ?
This is how it looks on firefox and IE browsers :
image
<https://user-images.githubusercontent.com/28390751/28165237-9ce8120e-67f0-11e7-99f0-4a73ddda70ae.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFQiA0jePgL6GnW4fZaWiqFDvnbQEytSks5sNgaZgaJpZM4L9ZMA>.
|
Closing and old issue. |
You can try:
https://chuckh.github.io/polymer-quill/components/polymer-quill/demo/index.html?dom=shadow
https://chuckh.github.io/polymer-quill/components/polymer-quill/demo/bubble.html?dom=shadow
The text was updated successfully, but these errors were encountered: