Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Characters with accented names not detected as the character token #28

Closed
1 of 6 tasks
arussbach opened this issue Jan 17, 2024 · 3 comments
Closed
1 of 6 tasks
Assignees
Labels
🐛 a/bug Type: Bug Effort
Milestone

Comments

@arussbach
Copy link

Describe the bug

If a characher has an accent in their name, it is not detected as a character.

What's the expected result?

If a character's name is written in cap locks, but contains an accent (ex: ÉTIENNE), it will not be centered as well as the subsequent dialogue.

Steps to reproduce the behavior

write :

ÉTIENNE
Hello, my name is Étienne.

and you will see the problem.

Fountain Editor - Plugin Version

v1.1.1

Obsidian Version

v1.5.3

What environment are you seeing the problem on?

  • MacOS
  • Windows
  • Linux
  • Android
  • iOS

Participation

  • I am willing to submit a pull request for this issue.
@chuangcaleb
Copy link
Owner

Hi! This should be because of the regex selector only simply selecting regular alphabetical characters, not accounting for accented letters — just like you diagnosed in your discord message to me.

Yeah yeah, I'll work on this soon! Thanks for opening the bug ticket!

@chuangcaleb chuangcaleb changed the title Characters with accent int their name not detected as characters 🐛 🐛 Characters with accented names not detected as the character token Jan 18, 2024
@chuangcaleb chuangcaleb self-assigned this Jan 25, 2024
@chuangcaleb chuangcaleb modified the milestones: MVP 1, MVP 2 Jan 25, 2024
chuangcaleb added a commit that referenced this issue Jan 25, 2024
@chuangcaleb chuangcaleb moved this from Todo to Done in obsidian-fountain-live Jan 25, 2024
@chuangcaleb chuangcaleb moved this from Done to In Progress in obsidian-fountain-live Jan 25, 2024
@chuangcaleb
Copy link
Owner

Extended the regex for Fountain's "character" token to the "capital" letters in the Latin-1 Supplement Unicode block. This should be enough.

Take note that the × (00D7, or ×) unicode character is technically included in the unicode range, so it's recognized as a capital letter, but it's too much regex work to exclude it, so meh.

If we need to extend to the capital letters of the Latin-extended blocks (A, B, whatever), those are much more complicated, please comment below on your requirements. If not, please mark this ticket as closed (I'm not sure if you can? or just comment that it works, then I'll close it myself)

SCR-20240125-kxkw

@chuangcaleb chuangcaleb added the 🐛 a/bug Type: Bug Effort label Jan 25, 2024
@arussbach
Copy link
Author

Oh! Great, thanks so much, it works perfectly for all my use casses!

@github-project-automation github-project-automation bot moved this from In Progress to Done in obsidian-fountain-live Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 a/bug Type: Bug Effort
Projects
Status: Done
Development

No branches or pull requests

2 participants