modules/kvs/kvstxn: Fix mem-leak in kvs merge

In kvstxn_create_empty(), the 'keys' array was created that could be overwritten without being destroyed. This was a corner case in PR flux-framework#1859, when key generation was altered. Fixes flux-framework#1944
chu11 · Jan 22, 2019 · 6c6068f · 6c6068f
1 parent 546f945
commit 6c6068f
Showing 1 changed file with 0 additions and 2 deletions.
diff --git a/src/modules/kvs/kvstxn.c b/src/modules/kvs/kvstxn.c
@@ -1289,8 +1289,6 @@ static kvstxn_t *kvstxn_create_empty (kvstxn_mgr_t *ktm, int flags)
         goto error_enomem;
     if (!(ktnew->ops = json_array ()))
         goto error_enomem;
-    if (!(ktnew->keys = json_array ()))
-        goto error_enomem;
     if (!(ktnew->names = json_array ()))
         goto error_enomem;
     if (!(ktnew->missing_refs_list = zlist_new ()))