Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Data.Text instead of ByteString in simple-grep example to match the Text usage in Iris.Colour.Formatting #94

Closed
lillycham opened this issue Oct 20, 2022 · 1 comment · Fixed by #95
Closed

Use Data.Text instead of ByteString in simple-grep example to match the Text usage in Iris.Colour.Formatting #94

lillycham opened this issue Oct 20, 2022 · 1 comment · Fixed by #95
Assignees
@lillycham
Labels
enhancement New feature or request
Milestone
v0.1.0.0: Improve...

Comments

@lillycham
Copy link
Contributor

No description provided.

@lillycham
Copy link
Contributor Author

Since this is dependent on my other PR #91, I'll open a PR for this when #91 is merged

@chshersh chshersh added the enhancement New feature or request label Oct 21, 2022
@lillycham lillycham mentioned this issue Oct 23, 2022
Merged
3 tasks
@chshersh chshersh added this to the v0.1.0.0: Improved UX milestone Jan 15, 2023
chshersh pushed a commit that referenced this issue Jan 15, 2023
@lillycham
[#94] Use Text in the simple-grep example to match changed Formatting…
243151f 
… API (#95)

* Change: ByteString > Text in Iris.Colour.Formatting
* Update changelog to reflect changes in Iris.Colour.Formatting API
* Remove: bytestring dependency
* Move #90 unto unreleased section of changelog
* Remove unneeded import in Iris.Colour.Formatting
* Modify grep example to use Data.Text
* remove redundant imports
* replace bs.readfile with text
* correct mdlint errors
* Update changelog, remove bytestring dependency from grep.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lillycham lillycham

Labels
enhancement New feature or request
Projects
No open projects
Iris Project
Status: Done
Milestone
v0.1.0.0: Improved UX
Development

Successfully merging a pull request may close this issue.

[#94] Use Text in the simple-grep example to match changed Formatting API lillycham/iris
2 participants
@chshersh @lillycham