Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of vcf-variant->protein-hgvs #22

Merged
merged 4 commits into from
Dec 5, 2018

Conversation

totakke
Copy link
Member

@totakke totakke commented Dec 3, 2018

Improves performance of vcf-variant->protein-hgvs by optimizing amino acid conversion and sequence retrieving. That can be checked with libra benchmark code.

before (commit 3ec5ed6):

$ lein libra :only varity.vcf-to-hgvs-bench

Measuring varity.vcf-to-hgvs-bench

vcf-variant->protein-hgvs-bench (vcf_to_hgvs_bench.clj:19)

  time: 97.077914 ms, sd: 113.403155 µs

after (commit ac184f7):

$ lein libra :only varity.vcf-to-hgvs-bench

Measuring varity.vcf-to-hgvs-bench

vcf-variant->protein-hgvs-bench (vcf_to_hgvs_bench.clj:19)

  time: 26.393281 ms, sd: 597.575155 ns

I confirmed lein test :all passed.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #22 into master will increase coverage by 0.14%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #22      +/-   ##
=========================================
+ Coverage   38.96%   39.1%   +0.14%     
=========================================
  Files          13      13              
  Lines        1468    1460       -8     
  Branches       31      31              
=========================================
- Hits          572     571       -1     
+ Misses        865     858       -7     
  Partials       31      31
Impacted Files Coverage Δ
src/varity/vcf_to_hgvs/protein.clj 29.19% <0%> (+0.62%) ⬆️
src/varity/codon.clj 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed554b...ac184f7. Read the comment docs.

Copy link
Member

@federkasten federkasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 🙆‍♂️
I have also confirmed these changes improve the performance drastically.

@federkasten federkasten merged commit d3c9073 into master Dec 5, 2018
@federkasten federkasten deleted the fix/vcf-to-phgvs-perf branch December 5, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants