Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format of uncertain protein mutation #8

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Fix format of uncertain protein mutation #8

merged 2 commits into from
Apr 21, 2023

Conversation

totakke
Copy link
Member

@totakke totakke commented Apr 20, 2023

fixes #7

(hgvs/format (hgvs/parse "p.(Met918Thr)")
             {:amino-acid-format :short})
;;=> "p.(M918T)"

@totakke totakke self-assigned this Apr 20, 2023
@totakke totakke requested a review from k-kom April 20, 2023 10:31
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #8 (017fe85) into master (ccf6558) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   89.08%   89.03%   -0.06%     
==========================================
  Files           5        5              
  Lines        1824     1824              
  Branches      127      127              
==========================================
- Hits         1625     1624       -1     
- Misses         72       73       +1     
  Partials      127      127
Impacted Files Coverage Δ
src/clj_hgvs/mutation.cljc 86.79% <100.00%> (-0.09%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

k-kom
k-kom approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@k-kom k-kom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix. LGTM

@k-kom k-kom merged commit 3b72cf2 into master Apr 21, 2023
@k-kom k-kom deleted the fix/uncertain-protein branch April 21, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-kom k-kom k-kom approved these changes

Assignees

@totakke totakke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does formatting uncertain protein change ignore format options?
2 participants
@totakke @k-kom