Simplify RFC 2822 comment parser #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good - looks like this disallows training whitespace which is consistent with the behavior pre acd4ecf. Only thought I had was changing the test strings to raw strings as the multiple levels of escaping is a bit tricky - I added a PR (#738) to this branch to do that, however please feel free to ignore if you think it's not necessary |
esheppa
approved these changes
Jul 25, 2022
Finomnis
suggested changes
Jul 25, 2022
There was a problem hiding this comment.
The reworked parser is quite elegant. I am ok with the removed trailing whitespace support, as it matches the RFC. I disagree with reducing whitespace down to the space character, which is not RFC conform. trim_left() seems to match the behaviour of the RFC closer.
Finomnis
suggested changes
Jul 25, 2022
Finomnis
reviewed
Jul 25, 2022
|
Created PR with fixes for my comments: #739 |
Finomnis
approved these changes
Jul 25, 2022
esheppa
approved these changes
Jul 25, 2022
|
Thanks, great collaboration here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweak the implementation from #733 to simplify the parser.
cc @Finomnis