Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run cargo publish, package #1540

Draft
wants to merge 1 commit into
base: 0.5.x
Choose a base branch
from

Conversation

jtmoon79
Copy link
Contributor

Test that cargo publish and cargo package succeed.

@jtmoon79 jtmoon79 force-pushed the jtmoon79-test_yml_run_publish_package branch from 9e75a32 to fc3e640 Compare March 24, 2024 00:34
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (21ee9b7) to head (aa6a2d5).

Additional details and impacted files
@@           Coverage Diff           @@
##            0.5.x    #1540   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files          37       37           
  Lines       16662    16662           
=======================================
  Hits        15656    15656           
  Misses       1006     1006           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtmoon79 jtmoon79 force-pushed the jtmoon79-test_yml_run_publish_package branch 5 times, most recently from 35da889 to 3d60ea0 Compare March 24, 2024 01:05
@jtmoon79 jtmoon79 force-pushed the jtmoon79-test_yml_run_publish_package branch from 3d60ea0 to aa6a2d5 Compare March 24, 2024 01:08
@pitdicker
Copy link
Collaborator

Thank you! What errors would this catch that our regular build and test CI runs don't catch?

@pitdicker
Copy link
Collaborator

pitdicker commented Apr 4, 2024

Just added a similar CI job for chrono-tz in chronotope/chrono-tz#158.
So I now see its use 😄.

@jtmoon79 Want to finish up this PR?

steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- run: cargo publish --locked --dry-run ${{ env.ALL_NON_EXCLUSIVE_FEATURES }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need --locked without a cargo.lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants