Merge 0.4.x #1169
Merged
Merge 0.4.x #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the "don't use me" panic into an error when using the parsing-only "%#z" formatter, consistent with other invalid formatters.
Add parse tests focused on timezone siganges "+", "-", and bad offsets
Replace test `test_tz_ascii_str` with more systemtatic test `test_timezonename_new`.
Function `timezone_offset_internal` and `TimeZoneName::new` iterate over the input data by `chars()` instead of iterating `as_bytes()`.
Timezone signage also allows MINUS SIGN (U+2212) as specified by ISO 8601 and RFC 3339. Not for RFC 2822 format or RFC 8536 transition string. Issue chronotope#835
`3:00:59 + 60s = 3:01:59`, not `3:02:00`
Co-authored-by: Yuxuan Shui <[email protected]>
Factor out formatting to `format/formatting.rs`
pitdicker
force-pushed
the
merge_0.4.x
branch
2 times, most recently
from
ac7d7dd to
19ea4c5
Compare
Merged
No functional change but makes this file self-consistent and consistent with the Dependabot docs.
Add more varying testing for most parsing functions. Tests emphasize whitespace, literals, timezones, and timezone delimiters (colons and whitespace). Add tests for multiple-byte characters and combining characters in and around data and parsing formats. These tests are added to aid humans verifying the next commit that changes parsing behavior. Issue chronotope#660
djc
approved these changes
Jul 24, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of difficult merge conflicts in
format/parse.rs.