Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ozone EGL initialization does not have DIR_ASSETS patch. #3213

Closed
magreenblatt opened this issue Nov 5, 2021 · 5 comments
Closed

Ozone EGL initialization does not have DIR_ASSETS patch. #3213

magreenblatt opened this issue Nov 5, 2021 · 5 comments
Labels
bug Bug report Framework Related to framework code or APIs

Comments

@magreenblatt
Copy link
Collaborator

Original report by PJB3005 (Bitbucket: PJB3005, GitHub: PJB3005).

linux_assets_path_1936.patch patches ui/gl/init/gl_initializer_linux_x11.cc so that it loads libEGL.so and libGLESv2.so from DIR_ASSETS. This patch is not mirrored to ui/ozone/common/egl_util.cc so initialization of EGL via Ozone does not use the patched load path (instead it uses DIR_MODULE which is executable relative on Linux instead of relative to libcef.so).

At least, this is what I could tell from digging through the source code of CEF/Chromium. I didn’t try compiling CEF to test whether a patch would fix this (sorry).
@magreenblatt
Copy link
Collaborator Author

Issue #3206 was marked as a duplicate of this issue.

@magreenblatt
Copy link
Collaborator Author

Linux: Load Ozone EGL binaries from DIR_ASSETS (fixes issue #3213)

→ <<cset 463ca625e1eb (bb)>>

@magreenblatt
Copy link
Collaborator Author

  • changed state from "new" to "resolved"

@magreenblatt
Copy link
Collaborator Author

Linux: Load Ozone EGL binaries from DIR_ASSETS (fixes issue #3213)

→ <<cset 23f5569e6930 (bb)>>

@magreenblatt
Copy link
Collaborator Author

Linux: Load Ozone EGL binaries from DIR_ASSETS (fixes issue #3213)

→ <<cset 89e80f799a59 (bb)>>

robincarlisle pushed a commit to robincarlisle/cef that referenced this issue Apr 28, 2023
@magreenblatt
Linux: Load Ozone EGL binaries from DIR_ASSETS (fixes issue chromiume…
463ca62 
…mbedded#3213)
filipnavara pushed a commit to emclient/cef that referenced this issue Dec 26, 2023
@magreenblatt
Linux: Load Ozone EGL binaries from DIR_ASSETS (fixes issue chromiume…
23f5569 
…mbedded#3213)
filipnavara pushed a commit to emclient/cef that referenced this issue Dec 26, 2023
@magreenblatt
Linux: Load Ozone EGL binaries from DIR_ASSETS (fixes issue chromiume…
89e80f7 
…mbedded#3213)
@magreenblatt magreenblatt mentioned this issue Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug report Framework Related to framework code or APIs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@magreenblatt