codec/h264: remove generic argument from NaluReader #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaluReaders are always short-lived and want to work with a reference, so we can just build them with it and simplify the code.
The data member does not need to be owned - it can simply be borrowed as a slice. Change that type to remove a generic argument (and introduce a lifetime), which simplifies the code a bit.
The bitstream member does not need to be owned - it can simply be borrowed as a slice. Change that type to remove a generic argument (and introduce a lifetime), which simplifies the code a bit.
The bitstream member does not need to be owned - it can simply be borrowed as a slice. Change that type to remove a generic argument (and introduce a lifetime), which simplifies the code a bit.
|
@dwlsalmeida do you think this can be merged? |
|
@Gnurou Yes, this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaluReaders are always short-lived and want to work with a reference, so we can just build them with it and simplify the code.