-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French translation - design systems for developers | react #777
French translation - design systems for developers | react #777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow great job @justine-tarlet 👏
I just quickly looked, I will continue this week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @justine-tarlet 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jonniebigodes I hope you're doing well 😃 It looks like @jeanphi-baconnais and I have finished translating and proofreading this translation. I've launched and checked the project locally, everything seems to be working fine. I wanted to know if you had any feedback on the translations or any other updates we should add? I think I also read that the gastby.config
file and the readme
should be updated, but I'm not sure which version to specify? (7.6
juste like the English version?)
Thanks in advance for your help, and have a nice day! 🙏
Than@justine-tarlet, sorry for not following up with you sooner. It's been a busy time here at Storybook, and I was tasked with other documentation changes. I've checked, and all is good on my end. I will be happy to merge this shortly. @jeanphi-baconnais, thank you so much for proofreading the translation. I appreciate it immensely 🙇. @justine-tarlet, regarding your question about the gatsby.config.js file and the Readme, don't worry; I can update them. So that you're aware, for now, it will be on the 7.6 version. I plan on updating this tutorial after the holidays. And if you're okay with it, we'd also love an updated translation. I hope both of you have a fantastic week. On behalf of the Storybook team, I wish you both a Merry Christmas and a Happy New Year. Stay safe |
Description
Here is the pull request for the french translation of design systems for developers (react version) : https://storybook.js.org/tutorials/design-systems-for-developers/react/en/introduction/.
I hope I opened the PR the right way 😄 , this is my first contribution, tell me if there is any problem.
Notes for translation
Here is some main vocabulary and suggested translations:
token de projet
?commiter
but we can also sayeffectuer un commit
relecture
andrevue
modules complémentaires
and also simplyaddons
flux de travail
but we could also leaveworkflow
Hope this translation will help 🙏 feel free to ask questions and make some feedbacks.
Have a nice day!