Svelte/spanish #302
Svelte/spanish #302
Conversation
docs(es): update docs
React native/spanish
… into Svelte/Spanish
… into Svelte/Spanish
|
@IvanSotelo i'll go over this tomorrow (tuesday) in more detail. So far i've skimmed through it and once again nothing to great stands out. The only concern is the create addon section that needs some changes. As you can see in #284 . If you follow along the issue you'll get the picture. I'm going to finish the draft i have to adjust the documentation and create a pr for this section of the documentation and once it's merged you make the required adjustments and we get this merged. Sounds good? |
|
Ok @jonniebigodes sounds good! |
There was a problem hiding this comment.
@IvanSotelo i just left in some comments, that need to be fixed and this should be good to go. Also check out the pr #304 for the rewording on the Create addons section. As soon as you address the changes i'll circle back and review them.
Also, i'm sorry for not reviewing it yesterday (tuesday) like i said in my previous comment. But as it was my last day on the company where i was working, the wife of one of my ex-colleagues baked me a cake and also a small care package and he dropped it in my house and we had a farewell skype party call with all the rest of the team's elements. and with that we ended up chatting a bit more as he's going to be a dad soon and he's a bit concerned with this situation, but the upside of all this is that he's home and can provide the future mom and son more attention.
Feel free to provide feedback.
There was a problem hiding this comment.
@IvanSotelo thanks for taking the time to address the proposed changes. Left one comment and when it's addressed and the create addons is updated this should be good to go.
Hope you're safe and well during these times.
There was a problem hiding this comment.
I've added suggestions to update this to be in line with recent changes in the English version. Specifically:
- Change
chromaticqa.comtochromatic.com - Change
app-codetoproject-token - Change
storybook-chromatictochromatic(the package)
All you have to do is accept the changes on your PR.
Good work on the translation 👍
|
@IvanSotelo sorry for not getting back to you sooner. I hope you're doing ok with all that's happening. I would like to ask you if you can address the comments that @ghengeveld suggested and also as #304 was merged you now have the create addons section properly fixed you can mop up the translation effort you put into this and we get it merged. Sounds good? Feel free to provide feedback. |
|
@jonniebigodes I'll go over it again this weekend and apply the changes, I'm sorry for not reviewing it before, but I have had a lot of work. Good that you are well. @ghengeveld thanks for your feedback, I will work on it. |
|
@IvanSotelo thank you very much for taking the time to address this. And really glad to hear back from you again. |
There was a problem hiding this comment.
@IvanSotelo we're almost good to go. Once again i can't stress enough and thank you for the time and effort you put into this. I left in some comments regarding some minor tweaks that need to be addressed. Once these are addressed this is good to go.
|
@IvanSotelo once again, can't thank you enough for the time and effort you put into this. I'm going to merge this. As it's good to go. Stay safe |
|
Hooray! Thank you @IvanSotelo and @jonniebigodes 🙇♂️ |
This pull request implements the spanish translation for the learnstorybook for Svelte. Ref #3