Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to sentinel upload failures. #1094

Merged
merged 5 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-node-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v3
with:
node-version: latest
node-version: 'lts/*'
- run: corepack enable
- run: yarn
- run: yarn build
Expand Down
8 changes: 7 additions & 1 deletion node-src/tasks/upload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import { rewriteErrorMessage, throttle } from '../lib/utils';
import { waitForSentinel } from '../lib/waitForSentinel';
import { Context, FileDesc, Task } from '../types';
import missingStatsFile from '../ui/messages/errors/missingStatsFile';
import sentinelFileErrors from '../ui/messages/errors/sentinelFileErrors';
import bailFile from '../ui/messages/warnings/bailFile';
import deviatingOutputDirectory from '../ui/messages/warnings/deviatingOutputDirectory';
import {
Expand Down Expand Up @@ -274,7 +275,12 @@ export const waitForSentinels = async (ctx: Context, task: Task) => {
})
);

await Promise.all(Object.values(sentinels).map((sentinel) => waitForSentinel(ctx, sentinel)));
try {
await Promise.all(Object.values(sentinels).map((sentinel) => waitForSentinel(ctx, sentinel)));
} catch (err) {
ctx.log.error(sentinelFileErrors());
throw err;
}
};

export default createTask({
Expand Down
7 changes: 7 additions & 0 deletions node-src/ui/messages/errors/sentinelFileErrors.stories.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import sentinelFileErrors from './sentinelFileErrors';

export default {
title: 'CLI/Messages/Errors',
};

export const SentinelFileErrors = () => sentinelFileErrors();
10 changes: 10 additions & 0 deletions node-src/ui/messages/errors/sentinelFileErrors.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import chalk from 'chalk';
import { dedent } from 'ts-dedent';

import { error } from '../../components/icons';
import link from '../../components/link';

export default () =>
dedent(chalk`
${error} Failed to finalize upload. Please check ${link('https://status.chromatic.com/')} or contact support.
`);
Loading