Implement UI for 'project linked' screen #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-3489 Finish implementing Project Linked page
This is unstyled at the moment, and for one thing the links don't open in new windows (which they probably should): https://www.notion.so/chromatic-ui/Chromatic-Visual-tests-addon-feedback-eeafb1ca806749d994fc62d4bf1653c9?pvs=4#6c22ac044e044d24a188feed7fb4eada |
ghengeveld
changed the title
weeksling
approved these changes
Aug 22, 2023
| @@ -683,6 +684,7 @@ export type PreparedBuildTestsArgs = { | |||
| first?: InputMaybe<Scalars['Int']['input']>; | |||
| last?: InputMaybe<Scalars['Int']['input']>; | |||
| orderBy?: InputMaybe<PreparedBuildTestsOrder>; | |||
| statuses?: InputMaybe<Array<TestStatus>>; | |||
There was a problem hiding this comment.
I think this is a good example of graphql updating unrelated because a change was made on chromatic, not in the addon itself. I would have thought this would have updated in this pr that queried for tests by statuses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the temporary mockup to look as designed. I did tweak the copy a bit.
📦 Published PR as canary version:
0.0.30--canary.42.7e80cf4.0✨ Test out this PR locally via: