Query testsForStory and testsForStatus separately to avoid pagination
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-3492 `Project.tests` API returns only 100 results
But storybooks can have a lot more than 100 tests. We either need to up the limit or (likely better) paginate. |
ghengeveld
requested review from
tmeasday,
weeksling and
thafryer
and removed request for
tmeasday
tmeasday
reviewed
Aug 18, 2023
There was a problem hiding this comment.
Looks like this PR should be telescoping on #36 (review) -- a bit hard to review as a result.
But the code changes to VisualTests.tsx look good. I'm a bit surprised there aren't more changes to the story data in VisualTests.stories.ts though?
ghengeveld
changed the base branch from
main
to
tom/ap-3450-buildinfo-component-errors-if-build-has-errors
…ors' into ghengeveld/ap-3492-projecttests-api-returns-only-100-results
|
@tmeasday You're right I forgot to commit+push some changes. I updated the base to telescope off your PR. |
tmeasday
reviewed
Aug 21, 2023
tmeasday
approved these changes
Aug 21, 2023
Base automatically changed from
tom/ap-3450-buildinfo-component-errors-if-build-has-errors
to
main
August 21, 2023 01:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than fetching all data for all tests on the build, we only query for all data for the tests for the currently selected story, and additionally fetch limited data for up to 1000 (max page size) tests that are in progress, pending, denied, failed or broken. This way we avoid having to do any kind of pagination logic.
In the unusual case that >1000 tests have such a status this will break down, but this is acceptable because it's used only to display status dots in the Storybook sidebar.
Depends on https://github.com/chromaui/chromatic/pull/7628
📦 Published PR as canary version:
0.0.29--canary.37.4a8d155.0✨ Test out this PR locally via: