Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Codecov #350

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Set up Codecov #350

merged 3 commits into from
Jan 15, 2025

Conversation

paulelliott
Copy link
Member

@paulelliott paulelliott commented Jan 14, 2025

This PR sets up code coverage reporting with Codecov. You can see the result of the run here.

📦 Published PR as canary version: 3.2.4--canary.350.958729f.0

✨ Test out this PR locally via:

npm install @chromatic-com/[email protected]
# or 
yarn add @chromatic-com/[email protected]

@paulelliott paulelliott marked this pull request as draft January 14, 2025 19:26
@paulelliott paulelliott self-assigned this Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@paulelliott paulelliott added the skip-release Auto: Preserve the current version when merged label Jan 14, 2025
@paulelliott paulelliott marked this pull request as ready for review January 14, 2025 19:28
@paulelliott paulelliott requested review from yannbf and valentinpalkovic and removed request for yannbf January 14, 2025 19:29
@paulelliott
Copy link
Member Author

@valentinpalkovic This is just added coverage reporting so we don't need to cut a release for it. I'm not sure how to set up the labels properly so can you fix those?

@valentinpalkovic valentinpalkovic added skip-release Auto: Preserve the current version when merged patch Auto: Increment the patch version when merged and removed skip-release Auto: Preserve the current version when merged labels Jan 15, 2025
@valentinpalkovic
Copy link
Contributor

Done!

@@ -96,6 +96,7 @@
"@typescript-eslint/parser": "^5.59.11",
"@urql/exchange-auth": "^2.1.6",
"@vitejs/plugin-react": "^3.1.0",
"@vitest/coverage-v8": "^2.1.8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid issues or conflicts, we should always make sure that all vitest related package versions are equal.

  • vitest
  • @vitest/coverage-v8

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@paulelliott paulelliott merged commit a7a43da into main Jan 15, 2025
7 checks passed
@paulelliott paulelliott deleted the set-up-codecov branch January 15, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants