Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading status of undefined in urql's didAuthError handler #349

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Dec 19, 2024

The response property may be undefined. This is not apparent from the urql docs but checks out when looking at the type definitions. I've opened a PR to improve the urql docs.

@ghengeveld ghengeveld added bug Classification: Something isn't working patch Auto: Increment the patch version when merged labels Dec 19, 2024
@ghengeveld ghengeveld changed the title Fix reading status of undefined Fix reading status of undefined in URQL's didAuthError handler Dec 19, 2024
@ghengeveld ghengeveld changed the title Fix reading status of undefined in URQL's didAuthError handler Fix reading status of undefined in urql's didAuthError handler Dec 19, 2024
@yannbf yannbf added the release Auto: Create a `latest` release when merged label Dec 19, 2024
@ghengeveld ghengeveld merged commit 982f9cb into main Dec 19, 2024
8 of 11 checks passed
@ghengeveld ghengeveld deleted the fix-auth-error-handler branch December 19, 2024 10:37
@ghengeveld
Copy link
Member Author

🚀 PR was released in v3.2.3 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants