Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stories for SidebarBottom #314

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Add stories for SidebarBottom #314

merged 2 commits into from
Jun 28, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 28, 2024 •
edited
Loading

Fixes #239

📦 Published PR as canary version: 1.5.1--canary.314.96ff63d.0

✨ Test out this PR locally via:

npm install @chromatic-com/[email protected]
# or 
yarn add @chromatic-com/[email protected]

@ghengeveld ghengeveld linked an issue May 28, 2024 that may be closed by this pull request
SidebarBottom: create story for visual test coverage #239
Closed
@ghengeveld ghengeveld requested a review from thafryer May 28, 2024 13:25
@ghengeveld ghengeveld added skip-release Auto: Preserve the current version when merged patch Auto: Increment the patch version when merged labels May 28, 2024
thafryer
thafryer approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment. SB team may be better suited to provide feedback.

src/components/SidebarBottom.stories.tsx Show resolved Hide resolved
@ghengeveld ghengeveld merged commit 2d1547a into main Jun 28, 2024
8 checks passed
@ghengeveld ghengeveld deleted the 239-sidebarbottom-create-story-for-visual-test-coverage branch June 28, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thafryer thafryer thafryer approved these changes

Assignees
No one assigned
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SidebarBottom: create story for visual test coverage
2 participants
@ghengeveld @thafryer