Filter Project.lastBuild query by localBuilds: { localBuildEmailHash } so we don't see others' local builds
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-3463 Pass current git user's email on local/uncommitted builds
If a build is local, rather than reading the commit's We could also consider using the logged in user's id and looking up their email, but I don't think there's any benefit in doing that. Also ensure we pass |
ghengeveld
approved these changes
Aug 8, 2023
Update OAuth Client ID
tmeasday
changed the title
Project.lastBuild query by creatorEmail so we don't see others' local buildsProject.lastBuild query by localBuilds: { localBuildEmailHash } so we don't see others' local builds
Realtime git info
ghengeveld
reviewed
Aug 11, 2023
ghengeveld
approved these changes
Aug 11, 2023
Add footer menu to link project screen
Upgrade to SB7.3
…f-outdated-builds Poll for Git repository hash and set `isOutdated` when it changes
Ensure we actually typecheck
…ent-git-users-email-on-localuncommitted-builds
tmeasday
deleted the
tom/ap-3463-pass-current-git-users-email-on-localuncommitted-builds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #25
Uses a canary from chromaui/chromatic-cli#796 and requires https://github.com/chromaui/chromatic/pull/7576 on the backend.
📦 Published PR as canary version:
0.0.27--canary.26.467eecc.0✨ Test out this PR locally via: