Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all builds from the addon as local #25

Merged
merged 11 commits into from
Aug 22, 2023
+49 −16
Merged

Mark all builds from the addon as local #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6254ba6
All builds from addon are local
tmeasday Aug 8, 2023
fcd0c78
Use the CLI to get git info, in particular `creatorEmail`
tmeasday Aug 8, 2023
58cb746
Change API for filtering `Project.lastBuild`
tmeasday Aug 10, 2023
52804b8
Switch to passing email hashes on `localBuilds` option
tmeasday Aug 10, 2023
06548e5
Update chromatic canary
tmeasday Aug 11, 2023
f902846
Upgrade canary again
tmeasday Aug 11, 2023
cdee056
Merge remote-tracking branch 'origin/main' into tom/ap-3463-pass-curr…
tmeasday Aug 17, 2023
bba0628
Update Chromatic dependency
tmeasday Aug 22, 2023
d47ab47
Fix merge conflicts
tmeasday Aug 22, 2023
467eecc
Merge pull request #26 from chromaui/tom/ap-3463-pass-current-git-use…
tmeasday Aug 22, 2023
44293d3
Merge remote-tracking branch 'origin/main' into tom/ap-3462-mark-addo…
tmeasday Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"dependencies": {
"@storybook/csf-tools": "^7.2.0",
"@storybook/design-system": "^7.15.11",
"chromatic": "^6.19.8",
"chromatic": "6.22.0-canary.0",
"date-fns": "^2.30.0",
"pluralize": "^8.0.0",
"urql": "^4.0.3"
Expand Down
12 changes: 7 additions & 5 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,14 @@ async function serverChannel(
channel.on(START_BUILD, async () => {
let sent = false;
await run({
flags: {
projectToken,
// We might want to drop this later and instead record "uncommitted hashes" on builds
forceRebuild: "",
},
// Currently we have to have this flag. We should move the check to after flags have been
// parsed into options.
flags: { projectToken },
options: {
// We might want to drop this later and instead record "uncommitted hashes" on builds
forceRebuild: true,
// Builds initiated from the addon are always considered local
isLocalBuild: true,
onTaskComplete(ctx: any) {
// eslint-disable-next-line no-console
console.log(`Completed task '${ctx.title}'`);
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5299,10 +5299,10 @@ chownr@^2.0.0:
resolved "https://registry.yarnpkg.com/chownr/-/chownr-2.0.0.tgz#15bfbe53d2eab4cf70f18a8cd68ebe5b3cb1dece"
integrity sha512-bIomtDF5KGpdogkLd9VspvFzk9KfpyyGlS8YFVZl7TGPBHL5snIOnxeshwVgPteQ9b4Eydl+pVbIyE1DcvCWgQ==

chromatic@^6.19.8:
version "6.20.0"
resolved "https://registry.yarnpkg.com/chromatic/-/chromatic-6.20.0.tgz#28dcbcc254e51bcb887d9b5203b3a11dd5ff890a"
integrity sha512-PN00MNAg++kXl9HM4JgTHJAMiJQ+nZYhtmKF+viZ6N//CLN5sZrHK5x5TSj/0z/cMhx2gGtbwgRhLHGGqxpj5w==
chromatic@6.22.0-canary.0:
version "6.22.0-canary.0"
resolved "https://registry.yarnpkg.com/chromatic/-/chromatic-6.22.0-canary.0.tgz#53a5bf12ccfc2f296279883f3f0fc4fb0a3aa5e5"
integrity sha512-TI2KtEZEUOJgQjUfUaZ0U8+l734spheW74/a+csMQ+gcATxYsI3TnoB1sHrszMGeTiTx5dbxPunG3OP6ThEsVw==

ci-info@^3.2.0:
version "3.8.0"
Expand Down