Skip to content

Commit

Permalink
Merge pull request #43 from chromaui/ghengeveld/ap-3490-removehide-re…
Browse files Browse the repository at this point in the history
…nder-settings-and-warnings-ui-toggles

Remove/hide render settings and warnings screens for now
  • Loading branch information
ghengeveld authored Aug 22, 2023
2 parents 28ae947 + 74b5c2e commit 088ce89
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 29 deletions.
46 changes: 23 additions & 23 deletions src/screens/VisualTests/VisualTests.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -327,26 +327,26 @@ export const InfrastructureError: Story = {
},
};

export const RenderSettings: Story = {
parameters: {
...withFigmaDesign(
"https://www.figma.com/file/GFEbCgCVDtbZhngULbw2gP/Visual-testing-in-Storybook?type=design&node-id=508-525764&t=18c1zI1SMe76dWYk-4"
),
},
play: playAll(async ({ canvasElement }) => {
const button = await findByRole(canvasElement, "button", { name: "Show render settings" });
await fireEvent.click(button);
}),
};

export const Warnings: Story = {
parameters: {
...withFigmaDesign(
"https://www.figma.com/file/GFEbCgCVDtbZhngULbw2gP/Visual-testing-in-Storybook?type=design&node-id=516-672810&t=18c1zI1SMe76dWYk-4"
),
},
play: playAll(async ({ canvasElement }) => {
const button = await findByRole(canvasElement, "button", { name: "Show warnings" });
await fireEvent.click(button);
}),
};
// export const RenderSettings: Story = {
// parameters: {
// ...withFigmaDesign(
// "https://www.figma.com/file/GFEbCgCVDtbZhngULbw2gP/Visual-testing-in-Storybook?type=design&node-id=508-525764&t=18c1zI1SMe76dWYk-4"
// ),
// },
// play: playAll(async ({ canvasElement }) => {
// const button = await findByRole(canvasElement, "button", { name: "Show render settings" });
// await fireEvent.click(button);
// }),
// };

// export const Warnings: Story = {
// parameters: {
// ...withFigmaDesign(
// "https://www.figma.com/file/GFEbCgCVDtbZhngULbw2gP/Visual-testing-in-Storybook?type=design&node-id=516-672810&t=18c1zI1SMe76dWYk-4"
// ),
// },
// play: playAll(async ({ canvasElement }) => {
// const button = await findByRole(canvasElement, "button", { name: "Show warnings" });
// await fireEvent.click(button);
// }),
// };
11 changes: 5 additions & 6 deletions src/screens/VisualTests/VisualTests.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Icons, Loader } from "@storybook/components";
import { Icon } from "@storybook/design-system";
// eslint-disable-next-line import/no-unresolved
import { GitInfo } from "chromatic/node";
import React, { useCallback, useEffect, useState } from "react";
Expand Down Expand Up @@ -363,7 +362,7 @@ export const VisualTests = ({
<Col>
<Text style={{ marginLeft: 5 }}>Latest snapshot on {build.branch}</Text>
</Col>
<Col push>
{/* <Col push>
<IconButton
active={settingsVisible}
aria-label={`${settingsVisible ? "Hide" : "Show"} render settings`}
Expand All @@ -372,7 +371,7 @@ export const VisualTests = ({
setWarningsVisible(false);
}}
>
<Icon icon="controls" />
<Icons icon="controls" />
</IconButton>
</Col>
<Col>
Expand All @@ -385,10 +384,10 @@ export const VisualTests = ({
}}
status="warning"
>
<Icon icon="alert" />2
<Icons icon="alert" />2
</IconButton>
</Col>
<Col>
</Col> */}
<Col push>
<FooterMenu setAccessToken={setAccessToken} />
</Col>
</Bar>
Expand Down

0 comments on commit 088ce89

Please sign in to comment.