Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Client close (redo of #1792) #2581

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Jul 26, 2024

Closes #1756

Refs:

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Docs about the new API can be stacked on top of this PR

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

tazarov commented Jul 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@tazarov
Copy link
Contributor Author

tazarov commented Aug 2, 2024

latest testcontainers with Chroma won't work with py38

@tazarov tazarov force-pushed the trayan-07-26-feat_client_close branch from d7de944 to ff3d64f Compare October 4, 2024 06:31
@tazarov tazarov marked this pull request as ready for review October 4, 2024 10:46
@tazarov tazarov force-pushed the trayan-07-26-feat_client_close branch from 89a1522 to d7de944 Compare October 14, 2024 06:21
@tazarov tazarov force-pushed the trayan-07-26-feat_client_close branch from d7de944 to e5c46da Compare October 14, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Ability to close local clients
1 participant