-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF]: Improved server-side serialization with orjson + async #1938
Changes from 9 commits
e98ab85
b99a1d4
bb075db
2a2b1f0
b5cf24e
ed53f6a
6d63a1f
a85b9a3
66afaf0
75fa386
a5f4683
c073bd8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,7 @@ def __init__(self, conn_pool: Pool, stack: local): | |
@override | ||
def __enter__(self) -> base.Cursor: | ||
if len(self._tx_stack.stack) == 0: | ||
self._conn.execute("PRAGMA case_sensitive_like = ON") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this meant to be included? It seems unrelated to the rest of the changes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I found this bug while testing the PR, so I added it here. I can split it up in another PR, as it is indeed unrelated. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move to PR or leave it here? |
||
self._conn.execute("BEGIN;") | ||
self._tx_stack.stack.append(self) | ||
return self._conn.cursor() # type: ignore | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason for this? it adds a small amount of cognitive overhead ("what's a cached property?") for no benefit that i can see?