-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Thread pool lru cache #1690
Closed
tazarov
wants to merge
5
commits into
chroma-core:main
from
amikos-tech:bugfix/per-thread-pool-lru-cache
Closed
[BUG]: Thread pool lru cache #1690
tazarov
wants to merge
5
commits into
chroma-core:main
from
amikos-tech:bugfix/per-thread-pool-lru-cache
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP - naive attempt Refs: chroma-core#1379
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
When is this fix going to be released. We are facing similar issue where file handles are growing infinitely even for global chroma client. |
We are running this issue frequently. Kindly give an ETA of fix. |
@HammadB, wdyt, does the PR make sense? |
Try to see if #1938 resolves this. |
Closing this in favor of #2014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The problem stems from how AnyIO handles synchronous calls when back pressure is on uvicorn. As it turns out, threads from the pool are used (max is 40); however, the thread contexts change, which causes the Connections to no longer be linked to thread-local but remain in the
_connections
set of the pool, leading to an infinite growth of open file handles (one per Connection). To solve this, an LRU cache is introduced to keep track of and clean up Connections that are not used for a configurable amount of time.Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytest
for python,yarn test
for jsDocumentation Changes
N/A