[ENH][SEC]: CIP-01022024 SSL Verify Client Config #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
…version require it. - Added openssl.cnf in tests
|
@HammadB, all issues resolved. Ready to go, PTAL. |
beggers
approved these changes
Jan 25, 2024
| ## Public Interfaces | ||
|
|
||
| New settings variable `chroma_server_ssl_verify` accepting either a boolean or a path to a certificate file. If the | ||
| value is a path to a certificate file, the file will be used to verify the server's certificate. The value is passed |
There was a problem hiding this comment.
What if the value is a boolean?
There was a problem hiding this comment.
Boolean means just ignore (false) or enforce (true) SSL cert verification. I'll document that.
|
|
||
| ## Public Interfaces | ||
|
|
||
| New settings variable `chroma_server_ssl_verify` accepting either a boolean or a path to a certificate file. If the |
There was a problem hiding this comment.
Could we specify that this settings variable only matters for clients? And probably document that fact in a comment next to the settings variable itself.
There was a problem hiding this comment.
I think we can go even further and add this to the official docs. Let me quickly have a look to see if it makes sense to add it somewhere.
|
@beggers, I think this is ready, but we need to add JS client parity here or in a quick follow-up. Wdyt? |
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 7, 2024
- Fixed and issue with isomorphic-fetch in the runtime. - Added scripts for creating SSL certs and running Chroma SSL server. - Added SSL tests. Refs: chroma-core#1604
|
@beggers, JS SSL support was added in a separate stacked PR. |
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 7, 2024
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 7, 2024
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 7, 2024
- Fixed utils to support isomorphic-fetch Response - Added some cleanups Refs: chroma-core#1604
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 9, 2024
- Fixed and issue with isomorphic-fetch in the runtime. - Added scripts for creating SSL certs and running Chroma SSL server. - Added SSL tests. Refs: chroma-core#1604
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 9, 2024
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 9, 2024
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 9, 2024
- Fixed utils to support isomorphic-fetch Response - Added some cleanups Refs: chroma-core#1604
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Feb 10, 2024
## Description of changes *Summarize the changes made by this PR.* - New functionality - New CIP to introduce SSL verify flag to support custom PKIs or to accept self-signed certs for testing and experimentation purposes ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python ## Documentation Changes CIP document in the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor pythonDocumentation Changes
CIP document in the PR.