[BUG]: Fixing broken peer deps #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed transformers and web-ai peer dependencies. Refs: chroma-core#1104
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
tested with [email protected] and 0.0.147 (Flowise version) |
|
we will plan to add these back, but let's get everything working again first |
Merged
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Sep 19, 2023
Refs: chroma-core#1104 ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Removed transformers and web-ai peer dependencies. ## Test plan *How are these changes tested?* - [ ] Manual testing - `mkdir testproject && cd testproject && npm init -y && npm link chromadb && npm add langchain` ## Documentation Changes N/A
tazarov
pushed a commit
to amikos-tech/chroma-core
that referenced
this pull request
Sep 19, 2023
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Sep 21, 2023
Refs: chroma-core#1104 ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Removed transformers and web-ai peer dependencies. ## Test plan *How are these changes tested?* - [ ] Manual testing - `mkdir testproject && cd testproject && npm init -y && npm link chromadb && npm add langchain` ## Documentation Changes N/A
tazarov
pushed a commit
to amikos-tech/chroma-core
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #1104
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
mkdir testproject && cd testproject && npm init -y && npm link chromadb && npm add langchainDocumentation Changes
N/A