Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Support for $in and $nin metadata filters #1151

Merged

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Sep 18, 2023

Refs: #1105

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • JS Client support for $in and $nin

Test plan

How are these changes tested?

  • Tests pass locally yarn test for js

Documentation Changes

TBD

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

const results = await collection.query({
queryTexts: ["test"],
nResults: 3,
where: { "float_value" : { '$nin': [-2,0] }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this says float, but they are ints?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked up the examples from clients/js/test/data.ts

const METADATAS = [
  { test: "test1", float_value: -2 },
  { test: "test2", float_value: 0 },
  { test: "test3", float_value: 2 },
];

@HammadB HammadB merged commit 5436bd5 into chroma-core:main Sep 20, 2023
@gururise
Copy link

gururise commented Oct 6, 2023

Any possible way to use this in python client?

@tazarov
Copy link
Contributor Author

tazarov commented Oct 9, 2023

@gururise, this was originally implemented for Python and only then came to JS. Check this: https://docs.trychroma.com/usage-guide?lang=py#using-inclusion-operators-in-and-nin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants