Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable manual workflow trigger #1036

Merged

Conversation

sunilkumardash9
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Added a workflow_dispatch to manually trigger test workflows
  • will be good for development experience

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@jeffchuber
Copy link
Contributor

@tazarov can you take a look at this?

@HammadB
Copy link
Collaborator

HammadB commented Aug 27, 2023

How does workflow dispatch work for unauthorized users

@tazarov
Copy link
Contributor

tazarov commented Aug 28, 2023

@HammadB @jeffchuber

Here's the 1 min read - https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow#configuring-a-workflow-to-run-manually

The gist:

To trigger a workflow in a repository, the user should be a collaborator with Write permission in the repository. Normally the external users can’t trigger workflows in the repository.

Ref: https://github.com/orgs/community/discussions/26053#discussioncomment-3250202

@tazarov
Copy link
Contributor

tazarov commented Aug 28, 2023

I think this can be useful.

On a side note: I am unsure whether this can be triggered on a PR branch - useful for some preliminary tests before doing the full 360.

@sunilkumardash9
Copy link
Contributor Author

sunilkumardash9 commented Aug 28, 2023

@tazarov The idea behind this is to run unit and integration tests on a forked repository manually. This could help anyone pushing changes to manually check if changes are passing checks before making PRs or testing existing PR branches without needing maintainers to approve them after every fix.

@tazarov
Copy link
Contributor

tazarov commented Aug 28, 2023

@tazarov The idea behind this is to run unit and integration tests on a forked repository manually. This could help anyone pushing changes to manually check if changes are passing checks before making PRs or testing existing PR branches without needing maintainers to approve them after every fix.

@sunilkumardash9, thanks for the clarification. I guess provided one enables GH Actions on a forked repo that should be possible, yes :)

@HammadB HammadB enabled auto-merge (squash) August 28, 2023 19:45
@HammadB
Copy link
Collaborator

HammadB commented Aug 28, 2023

Looks great! Thanks!

@HammadB
Copy link
Collaborator

HammadB commented Aug 28, 2023

You'll have to rebase on #1054

auto-merge was automatically disabled August 29, 2023 13:49

Head branch was pushed to by a user without write access

@sunilkumardash9 sunilkumardash9 force-pushed the enable-manual-workflow-trigger branch from 490fef4 to afa2823 Compare August 29, 2023 13:49
@HammadB HammadB enabled auto-merge (squash) September 4, 2023 16:32
@tazarov
Copy link
Contributor

tazarov commented Sep 6, 2023

@sunilkumardash9, your rebase did not work. Can you do it again?

@sunilkumardash9
Copy link
Contributor Author

@tazarov It should be passing now.

@HammadB HammadB merged commit 6681df9 into chroma-core:main Sep 14, 2023
@HammadB
Copy link
Collaborator

HammadB commented Sep 15, 2023

@sunilkumardash9 thanks for the add

tazarov pushed a commit to amikos-tech/chroma-core that referenced this pull request Sep 15, 2023
## Description of changes

*Summarize the changes made by this PR.*
 - Added a workflow_dispatch to manually trigger test workflows
 - will be good for development experience

---------

Signed-off-by: sunilkumardash9 <[email protected]>
tazarov pushed a commit to amikos-tech/chroma-core that referenced this pull request Sep 21, 2023
## Description of changes

*Summarize the changes made by this PR.*
 - Added a workflow_dispatch to manually trigger test workflows
 - will be good for development experience

---------

Signed-off-by: sunilkumardash9 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants