Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add dep fix for pydantic in thin client #1033

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Aug 24, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
  • New functionality
    • ...

Test plan

Existing tests for client

  • Tests pass locally with pytest for python, yarn test for js

Documentation Changes

None

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB HammadB changed the title Add dep fix for pydantic in thin client [BUG] Add dep fix for pydantic in thin client Aug 24, 2023
@jeffchuber jeffchuber self-requested a review August 24, 2023 05:44
@tazarov tazarov mentioned this pull request Aug 25, 2023
1 task
@HammadB
Copy link
Collaborator Author

HammadB commented Aug 28, 2023

Need to rebase on #1054

@HammadB HammadB enabled auto-merge (squash) August 28, 2023 21:39
@HammadB HammadB merged commit fd014ed into main Aug 28, 2023
tazarov pushed a commit to amikos-tech/chroma-core that referenced this pull request Aug 30, 2023
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- chroma-core#799 introduced a max version for pydantic but this change was not
propagated to the thin client. This makes the same change in the thin
client.
 - New functionality
	 - ...

## Test plan
Existing tests for client

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants