Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: chroma:document as metadata key #1717

Closed
tazarov opened this issue Feb 14, 2024 · 0 comments · Fixed by #1718
Closed

[Bug]: chroma:document as metadata key #1717

tazarov opened this issue Feb 14, 2024 · 0 comments · Fixed by #1718
Labels
bug Something isn't working

Comments

@tazarov
Copy link
Contributor

tazarov commented Feb 14, 2024

What happened?

The metadata key is ignore (aka overridden by WAL processing)

col_bug = client.get_or_create_collection("buggyone")

col_bug.upsert(ids=["1"],documents=["my doc"],metadatas=[{"chroma:document":"this be document"}])

Metadata key overrides the document:

col_bug.update(ids=["1"],metadatas=[{"chroma:document":"this be document"}])

Versions

Chroma: 0.4.x, OS: Any, Python: Any

Relevant log output

No response
@tazarov tazarov added the bug Something isn't working label Feb 14, 2024
tazarov added a commit to amikos-tech/chroma-core that referenced this issue Feb 14, 2024
@tazarov
fix: Adding validation check for "chroma:document" in metadata.
40d0190 
Refs: chroma-core#1717
@tazarov tazarov mentioned this issue Feb 14, 2024
Merged
1 task
HammadB pushed a commit that referenced this issue Feb 14, 2024
@tazarov
[BUG]: Adding validation check for "chroma:document" in metadata. (#1718
da68516 
)

Closes: #1717

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Fixed an issue where if the metadata key is set to `chroma:document`
it is either ignore when inserting or overrides the actual document when
updating records by `id`

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python, `yarn test` for js

## Documentation Changes
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG]: Adding validation check for "chroma:document" in metadata. amikos-tech/chroma-core
1 participant
@tazarov