added language code support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…neal/pyccuweather into feature/languagesupport
…ion. patched a way to handle them
|
@chrisvoncsefalvay let me know if this needs any adjustments. thanks |
|
LGTM. |
|
Hm. For some reason this breaks the build. I will look into this in a second although I no longer have access to Accuweather so I have a hard time testing things ;) Thanks @stephenoneal @gdw2 ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a LANGUAGE property which is set on init of Connector and is used in building the parameter payload so that the multi-lingual information can be pulled down from accuweather's api using the ISO 639-1 language code that is supports.. Default is 'EN' for English.