Merge pull request #235 from qkdreyer/master

Fixed empty file written to outputPath
chrisvfritz · Aug 17, 2018 · a501698 · a501698
2 parents 8abb6ec + d890455
commit a501698
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/es5-autogenerated/index.js b/es5-autogenerated/index.js
@@ -133,10 +133,8 @@ PrerenderSPAPlugin.prototype.apply = function (compiler) {
         return mkdirp(path.dirname(processedRoute.outputPath)).then(function () {
           return new Promise(function (resolve, reject) {
             compilerFS.writeFile(processedRoute.outputPath, processedRoute.html.trim(), function (err) {
-              if (err) reject(`[prerender-spa-plugin] Unable to write rendered route to file "${processedRoute.outputPath}" \n ${err}.`);
+              if (err) reject(`[prerender-spa-plugin] Unable to write rendered route to file "${processedRoute.outputPath}" \n ${err}.`);else resolve();
             });
-
-            resolve();
           });
         }).catch(function (err) {
           if (typeof err === 'string') {
@@ -153,8 +151,9 @@ PrerenderSPAPlugin.prototype.apply = function (compiler) {
       done();
     }).catch(function (err) {
       PrerendererInstance.destroy();
-      console.error('[prerender-spa-plugin] Unable to prerender all routes!');
-      compilation.errors.push(new Error('[prerender-spa-plugin] Unable to prerender all routes!'));
+      var msg = '[prerender-spa-plugin] Unable to prerender all routes!';
+      console.error(msg);
+      compilation.errors.push(new Error(msg));
       done();
     });
   };

diff --git a/es6/index.js b/es6/index.js
@@ -121,9 +121,8 @@ PrerenderSPAPlugin.prototype.apply = function (compiler) {
               return new Promise((resolve, reject) => {
                 compilerFS.writeFile(processedRoute.outputPath, processedRoute.html.trim(), err => {
                   if (err) reject(`[prerender-spa-plugin] Unable to write rendered route to file "${processedRoute.outputPath}" \n ${err}.`)
+                  else resolve()
                 })
-
-                resolve()
               })
             })
             .catch(err => {
@@ -143,9 +142,10 @@ PrerenderSPAPlugin.prototype.apply = function (compiler) {
       })
       .catch(err => {
         PrerendererInstance.destroy()
-        console.error('[prerender-spa-plugin] Unable to prerender all routes!');
-        compilation.errors.push( new Error( '[prerender-spa-plugin] Unable to prerender all routes!' ) );
-        done();
+        const msg = '[prerender-spa-plugin] Unable to prerender all routes!'
+        console.error(msg)
+        compilation.errors.push(new Error(msg))
+        done()
       })
   }
 

diff --git a/package.json b/package.json
@@ -37,6 +37,10 @@
       "name": "Joshua Bemenderfer",
       "email": "[email protected]",
       "url": "https://joshderf.com/"
+    },
+    {
+      "name": "qkdreyer",
+      "email": "[email protected]"
     }
   ],
   "repository": "chrisvfritz/prerender-spa-plugin",