Skip to content

Commit

Permalink
Remove @SoLoaderLibrary to avoid OSS breakage (facebook#36821)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebook#36821

About SoLoaderLibrary:
```
/**
 * This class is used to mark Java classes that depend on native libraries.
 *
 * <p>The purpose is to enable compile-time checking of library renaming. Adding a native target to
 * the native library merge map will cause its library name to change in release builds, which
 * SoLoader only supports if the target sets allow_jni_merging = True.
 *
 * <p>By publishing the library names to Buck via this annotation, we can validate at build time
 * that this parameter is set.
 */
```
This annotation is not supported in OSS so move it to avoid breakage

Changelog:
[Android][Changed] -Remove SoLoaderLibrary to avoid OSS breakage

Reviewed By: cortinico

Differential Revision: D44679498

fbshipit-source-id: 6255e3c5f011d999d5e5aa6ae756a783bea2ee77
  • Loading branch information
Lulu Wu authored and facebook-github-bot committed Apr 19, 2023
1 parent 81c1153 commit 537c28a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,8 @@
import com.facebook.react.bridge.WritableNativeArray;
import com.facebook.react.modules.core.JavaScriptTimerExecutor;
import com.facebook.soloader.SoLoader;
import com.facebook.soloader.annotation.SoLoaderLibrary;

@Nullsafe(Nullsafe.Mode.LOCAL)
@SoLoaderLibrary("rninstance")
public class JSTimerExecutor implements JavaScriptTimerExecutor {

static {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
import com.facebook.react.uimanager.ViewManagerResolver;
import com.facebook.react.uimanager.events.EventDispatcher;
import com.facebook.soloader.SoLoader;
import com.facebook.soloader.annotation.SoLoaderLibrary;
import com.facebook.systrace.Systrace;
import java.util.ArrayList;
import java.util.Collection;
Expand All @@ -69,7 +68,6 @@
*/
@Nullsafe(Nullsafe.Mode.LOCAL)
@ThreadSafe
@SoLoaderLibrary({"rninstance"})
public final class ReactInstance {

private static final String TAG = ReactInstance.class.getSimpleName();
Expand Down

0 comments on commit 537c28a

Please sign in to comment.