Skip to content
This repository has been archived by the owner on Sep 20, 2020. It is now read-only.

$transition not returning promise correctly #152

Closed
christopherthielen opened this issue Feb 2, 2015 · 1 comment
Closed

$transition not returning promise correctly #152

christopherthielen opened this issue Feb 2, 2015 · 1 comment
Assignees
@christopherthielen
Labels
bug transition
Milestone
0.0.13

Comments

@christopherthielen
Copy link
Owner

from @shanesmith in #150

Also running into @jvisser's issue so I've created a plunkr below.

http://plnkr.co/edit/po3jqSI7swYrAVaUFwxj?p=preview

Some quick sleuthing tell me that the bug is somehow related to https://github.com/christopherthielen/ui-router-extras/blob/master/src/transition.js#L43 and how it's used a few dozen lines below, probably should be returning data instead...
@christopherthielen christopherthielen added this to the 0.0.13 milestone Feb 2, 2015
@christopherthielen christopherthielen self-assigned this Feb 2, 2015
@shanesmith
Copy link

Cheers!

impatient pushed a commit to impatient/ui-router-extras that referenced this issue Feb 5, 2015
@christopherthielen
fix(transition): transition promise now resolved correctly
38c1262 
closes christopherthielen#152
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christopherthielen christopherthielen

Labels
bug transition
Projects
None yet
Milestone
0.0.13
Development

No branches or pull requests
2 participants
@shanesmith @christopherthielen