Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix with configuration #58

Merged
merged 11 commits into from
Mar 27, 2021
Merged

Bug fix with configuration #58

merged 11 commits into from
Mar 27, 2021

Conversation

chrisleekr
Copy link
Owner

@chrisleekr chrisleekr commented Mar 26, 2021

Description

There were several reports that the configuration is not working as expected. And found the code had a typo.

Related Issue

#57
#54
#52

Motivation and Context

How Has This Been Tested?

Tested with the Binance test server in my local development environment.

Screenshots (if appropriate):

Global settings

Screen Shot 2021-03-26 at 15 01 25

Screen Shot 2021-03-26 at 15 01 57

Screen Shot 2021-03-26 at 15 04 05

Symbol setting

Screen Shot 2021-03-26 at 15 05 16

Screen Shot 2021-03-26 at 15 06 02

@chrisleekr chrisleekr marked this pull request as draft March 26, 2021 00:28
@codecov-io
Copy link

Codecov Report

Merging #58 (2117f6a) into master (c73ff5b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #58   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        40    +2     
  Lines          780       819   +39     
  Branches        84        86    +2     
=========================================
+ Hits           780       819   +39     
Impacted Files Coverage Δ
app/helpers/mongo.js 100.00% <100.00%> (ø)
app/jobs/trailingTrade/configuration.js 100.00% <100.00%> (ø)
app/jobs/trailingTrade/step/get-indicators.js 100.00% <100.00%> (ø)
app/jobs/trailingTrade/step/place-buy-order.js 100.00% <100.00%> (ø)
app/jobs/trailingTrade/step/place-sell-order.js 100.00% <100.00%> (ø)
app/jobs/trailingTrade/symbol.js 100.00% <100.00%> (ø)
app/websocket/configure.js 100.00% <100.00%> (ø)
app/websocket/handlers/index.js 100.00% <100.00%> (ø)
app/websocket/handlers/latest.js 100.00% <100.00%> (ø)
app/websocket/handlers/setting-update.js 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73ff5b...2117f6a. Read the comment docs.

@chrisleekr chrisleekr marked this pull request as ready for review March 27, 2021 04:47
@chrisleekr chrisleekr merged commit 408f52d into master Mar 27, 2021
Copy link

@markgifford49 markgifford49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@markgifford49 markgifford49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safari

@chrisleekr chrisleekr deleted the update-configurations branch May 21, 2021 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants