Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide temporarily disabled trading coins from the dashboard #552

Merged
merged 2 commits into from
Dec 9, 2022

Conversation

rando128
Copy link
Contributor

@rando128 rando128 commented Dec 5, 2022

Description

The feature allows the user to hide coins for which buy and sell tradings have been disabled, removing the clutter from the dashboard.

Motivation and Context

When I manage many coins, I often struggle to easily access active coins in the dashboard despite the existing sorting options. Hiding disabled coins is a way to improve the usability. This PR extends the selectedSortOption object with a new hideInactive attribute.

2 UX features have been implemented:

  • Hide inactive trades checkbox in the Sorting popup (FilterIcons.js)
  • Add a label in the trading status bar (App.js) to remind inactive coins are hidden

How Has This Been Tested?

It is working on my setup.

Screenshots (if appropriate):

Screenshot 2022-12-05 at 20 56 05

Screenshot 2022-12-05 at 21 20 14

@chrisleekr chrisleekr added the enhancement New feature or request label Dec 5, 2022
@chrisleekr chrisleekr assigned chrisleekr and rando128 and unassigned chrisleekr Dec 5, 2022
@chrisleekr chrisleekr self-requested a review December 5, 2022 20:26
@chrisleekr chrisleekr merged commit 1124160 into chrisleekr:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants