Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle execution report #495

Merged
merged 8 commits into from
Aug 27, 2022
Merged

Conversation

chrisleekr
Copy link
Owner

Description

This PR is to fix the issue #494

Related Issue

#494

Motivation and Context

Refer #494

How Has This Been Tested?

A test case is written and running on my development server.

Screenshots (if appropriate):

@chrisleekr chrisleekr self-assigned this Aug 27, 2022
@chrisleekr chrisleekr added the bug Something isn't working label Aug 27, 2022
@chrisleekr chrisleekr linked an issue Aug 27, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2022

Codecov Report

Merging #495 (cad5524) into master (5daea00) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #495   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           90        90           
  Lines         3315      3335   +20     
  Branches       559       559           
=========================================
+ Hits          3315      3335   +20     
Impacted Files Coverage Δ
app/binance/user.js 100.00% <100.00%> (ø)
...lingTrade/step/ensure-grid-trade-order-executed.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@habibalkhabbaz
Copy link
Contributor

Hello @chrisleekr
It seems everything fine!
I just added one comment but we are good to go.

app/binance/user.js Outdated Show resolved Hide resolved
@chrisleekr chrisleekr merged commit 74793d1 into master Aug 27, 2022
@chrisleekr chrisleekr deleted the fix/handle-execution-report branch September 20, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated order status causes mutliple grid trade execution
3 participants