Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for PPM save #4

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Add test for PPM save #4

merged 3 commits into from
Feb 28, 2024

Conversation

chrislawlor
Copy link
Owner

@chrislawlor chrislawlor commented Feb 27, 2024

This PR shows coveralls reporting of two changes:

  • Added a test to increase existing coverage of pytracer/image.py
  • Added some new, untested code.

Setup notes:

GH action setup guide here: https://github.com/marketplace/actions/coveralls-github-action. It's really simple, just this:

      - name: coveralls
        uses: coverallsapp/github-action@v2

Have to add COVERALLS_REPO_TOKEN as a repository secret. It seems each repo gets its own token.

Have to enable comments in the repo settings:

image

I also had to add the @coveralls user, to allow it to add comments.

PR comments didn't seem to work right away, and they take about a min or so to show up. Subsequent commits overwrite the previous comment, which is nice.

Other notes

This repo didn't have any CI set up, so I borrowed most of the GH action setup from https://jacobian.org/til/github-actions-poetry/.

@coveralls
Copy link
Collaborator

coveralls commented Feb 27, 2024

Pull Request Test Coverage Report for Build 8082108182

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 95.822%

Totals Coverage Status
Change from base Build 8070512604: 0.4%
Covered Lines: 688
Relevant Lines: 718

💛 - Coveralls

@chrislawlor
Copy link
Owner Author

Since I think no one will be able to click into Coveralls, here's what I get when I click on pytracer/canvas.py link above:

image

@chrislawlor
Copy link
Owner Author

And the big Build 8070578468 link:

image

@chrislawlor
Copy link
Owner Author

If I click on the "Changed" tab at the bottom, I get a summary of coverage changes:

image

which clearly show that coverage of canvas.py has gone down (new untested code), and image.py has gone up (new test).

@chrislawlor chrislawlor merged commit 72c9158 into main Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants