ui: Remove "?" from confirmation-dialog titles

Discussion: zulip#5439 (comment)
chrisbobbe · Aug 31, 2022 · f5e8fc0 · f5e8fc0
1 parent 8724759
commit f5e8fc0
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 6 deletions.
diff --git a/src/account-info/ProfileScreen.js b/src/account-info/ProfileScreen.js
@@ -99,7 +99,7 @@ function LogoutButton(props: {||}) {
       onPress={() => {
         showConfirmationDialog({
           destructive: true,
-          title: 'Log out?',
+          title: 'Log out',
           message: {
             text: 'This will log out {email} on {realmUrl} from the mobile app on this device.',
             values: { email: identity.email, realmUrl: identity.realm.toString() },

diff --git a/src/account/AccountPickScreen.js b/src/account/AccountPickScreen.js
@@ -55,7 +55,7 @@ export default function AccountPickScreen(props: Props): Node {
       const { realm, email } = accounts[index];
       showConfirmationDialog({
         destructive: true,
-        title: 'Remove account?',
+        title: 'Remove account',
         message: {
           text: 'This will make the mobile app on this device forget {email} on {realmUrl}.',
           values: { realmUrl: realm.toString(), email },

diff --git a/src/streams/EditStreamCard.js b/src/streams/EditStreamCard.js
@@ -312,7 +312,7 @@ export default function EditStreamCard(props: Props): Node {
 
         showConfirmationDialog({
           destructive: true,
-          title: 'Discard changes?',
+          title: 'Discard changes',
           message: 'You have unsaved changes. Leave without saving?',
           onPressConfirm: () => navigation.dispatch(e.data.action),
           _,

diff --git a/src/utils/info.js b/src/utils/info.js
@@ -49,7 +49,14 @@ export const showErrorAlert = (
 
 export const showConfirmationDialog = (args: {|
   +destructive?: true,
+
+  /**
+   * As in the web app, very brief, sentence case, no question mark
+   *
+   * E.g., "Delete topic".
+   */
   +title: LocalizableText,
+
   +message: LocalizableText,
   +learnMoreButton?: LearnMoreButton,
   +onPressConfirm: () => void,

diff --git a/static/translations/messages_en.json b/static/translations/messages_en.json
@@ -2,7 +2,7 @@
   "Confirm": "Confirm",
   "Configure permissions": "Configure permissions",
   "You": "You",
-  "Discard changes?": "Discard changes?",
+  "Discard changes": "Discard changes",
   "You have unsaved changes. Leave without saving?": "You have unsaved changes. Leave without saving?",
   "Who can access the stream?": "Who can access the stream?",
   "Cannot apply requested settings": "Cannot apply requested settings",
@@ -84,7 +84,6 @@
   "Enter": "Enter",
   "Switch account": "Switch account",
   "Log out": "Log out",
-  "Log out?": "Log out?",
   "This will log out {email} on {realmUrl} from the mobile app on this device.": "This will log out {email} on {realmUrl} from the mobile app on this device.",
   "Add new account": "Add new account",
   "Search messages": "Search messages",
@@ -318,7 +317,7 @@
   "Working remotely": "Working remotely",
   "This message was hidden because it is from a user you have muted. Long-press to view.": "This message was hidden because it is from a user you have muted. Long-press to view.",
   "Signed out": "Signed out",
-  "Remove account?": "Remove account?",
+  "Remove account": "Remove account",
   "This will make the mobile app on this device forget {email} on {realmUrl}.": "This will make the mobile app on this device forget {email} on {realmUrl}.",
   "Oops! Something went wrong.": "Oops! Something went wrong.",
   "Uploading {fileName}...": "Uploading {fileName}...",