Support submetrics #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to fix the way we detect if there are wultiple values per metrics so this is still WIP |
roidelapluie
force-pushed
the
submetrics
branch
from
34f1d33
to
6192d94
Compare
|
Fixed, and added tests. |
disq
approved these changes
Dec 1, 2017
bruth
reviewed
Dec 1, 2017
config_test.go
Outdated
| want: []*Query{ | ||
| &Query{ | ||
| Name: "query_ds_1", | ||
| SQL: "select 1 as \"sum\", 2 as \"count\" from dual\n", |
There was a problem hiding this comment.
Prefer literal strings (backticks) when using double quotes in a string.
`select 1 as "sum" ...`
set.go
Outdated
| } | ||
| } | ||
| // it is a facet field and not a submetric field | ||
| if submetric == false { |
There was a problem hiding this comment.
Prefer if !submetric { rather than equality to false.
|
Looks good otherwise! |
Fixes chop-dbhi#36 Signed-off-by: Julien Pivotto <[email protected]>
roidelapluie
force-pushed
the
submetrics
branch
from
6192d94
to
6734bda
Compare
|
@bruth I addressed your comments. |
|
👍 Nice work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36
Signed-off-by: Julien Pivotto [email protected]