New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ADD in Dockerfile to follow Docker best practices #17

Closed

haxorof opened this issue Jul 8, 2017 · 0 comments

Assignees

Labels

project

Milestone

Contributor

haxorof commented Jul 8, 2017

ADD today fetches the release here from Github but according to Docker best practices this kind of use of ADD shall be avoided:

https://docs.docker.com/engine/userguide/eng-image/dockerfile_best-practices/#add-or-copy

Construct similar to this shall be used instead:

RUN mkdir -p /usr/src/things \
    && curl -SL http://example.com/big.tar.xz \
    | tar -xJC /usr/src/things \
    && make -C /usr/src/things all

haxorof added the project label

haxorof self-assigned this

haxorof added a commit that referenced this issue


          Fixes #17

97f1230

haxorof added this to the 1.2.0 milestone

haxorof closed this as completed in

3876dc5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment