Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add note about maintaining control of a component #89

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Conversation

ungoldman
Copy link
Member

Taking a crack at adding a note to the docs to clarify the issue seen in #88.

Feel free to suggest better wording 😄

cc @mafintosh @bcomnes

Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcomnes
Copy link
Contributor

bcomnes commented Feb 10, 2019

Not sure why tests are failing.

@bcomnes bcomnes merged commit e567b2c into master Feb 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the readme branch February 10, 2019 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants