-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CONTRIBUTING & CODE_OF_CONDUCT #587
base: master
Are you sure you want to change the base?
Conversation
Should we have more than one maintainer listed I think in case there are issues with the maintainer listed? I like the examples section since it helps clarify the course of action. |
what @toddself said! might also be helpful if you're away etc. i heard its good to have an un-even number in case you need to take a vote / reach consensus on an issue. otherwise looks good! glad you decided to adopt the WeAllJs version! |
yea, pencil me in!
…On Sat, 21 Oct 2017 at 01:49 Yoshua Wuyts ***@***.***> wrote:
@lrlna <https://github.com/lrlna> @toddself <https://github.com/toddself>
can I pencil the both of you in then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#587 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHu3CPMM0rM7Fi79i0Cq5fp4gdmMabYjks5suTFzgaJpZM4QA7Fp>
.
|
Hmmm, we never ended up merging this. Think the wording in this CoC is not ideal tbh. Using contributor covenant might make a bit more sense for us? Better understood, and probably easier to follow. Example: https://github.com/choojs/bankai/blob/f7d988e0ab609a83a11f90389f0fa0765167b677/.github/CODE_OF_CONDUCT.md |
Why do you think the contributor covenant is better for this?
…On Thu, Feb 1, 2018, 10:16 Yoshua Wuyts ***@***.***> wrote:
Hmmm, we never ended up merging this. Think the wording in this CoC is not
ideal tbh.
Using contributor covenant might make a bit more sense for us? Better
understood, and probably easier to follow. Example:
https://github.com/choojs/bankai/blob/f7d988e0ab609a83a11f90389f0fa0765167b677/.github/CODE_OF_CONDUCT.md
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#587 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHu3CPaRDxHAkRc1QLwtOL5PcFd4wF_dks5tQYDwgaJpZM4QA7Fp>
.
|
@lrlna I made a Frankenstein edited version of a different CoC. The Contributor Covenant is nice & to the point; good enough that people might actually read the thing. |
@yoshuawuyts gotcha! |
+1 for contributor covenant, it's well known, well documented, and versioned. Easy to link to in contributing docs or copy to a |
Adds a contributing file, and code of conduct as per choojs/discuss#5. Hope this good; please do give it a read. Thanks!
Todo