Correct model namespace example #143
Conversation
|
Oh yeah, lgtm! |
| reducers: { | ||
| add: (data, state) => ({ todos: state.todos.concat(data.payload) }) | ||
| add: (data, state) => ({ todos: state.items.concat(data.payload) }) |
There was a problem hiding this comment.
Is the key of the returned object the namespace?
I'd expect it to be the new state, so instead of ({ todos: state.items.concat(data.payload) })
I'd thought it would be ({ items: state.items.concat(data.payload) }).
There was a problem hiding this comment.
@yoshuawuyts I can try to work some git ninjitsu and amend the commit and push to master, or create another pull request
There was a problem hiding this comment.
I'd rather we not force push to master; might even disable that from settings - feel free to just push a new commit tho, it's just docs and the fix is straight forward so no need to run CI ✨
There was a problem hiding this comment.
Forgot that would require a force push, thx. posted PR
The current docs use
myTodosin the code buttodosin the narrative. This PR makes the narrative match the code and usestodosanditemsto differentiate between the namespace and the array in the state.