-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare umd build before publish #108
Conversation
just-boris
commented
Jul 1, 2016
- added browserify build on prepublish hook
- added example how to use UMD build
- updated package.json to exclude unnecessary files from npm package (examples and test)
fixes #105 |
@@ -10,7 +10,11 @@ | |||
"test:browser": "standard && npm run deps && NODE_ENV=test zuul tests/browser/*", | |||
"test:browser:local": "standard && npm run deps && NODE_ENV=test zuul --local 8080 -- tests/browser/*", | |||
"test:cov": "npm run test:server:cov && npm run test:browser", | |||
"test": "npm run test:server && npm run test:browser" | |||
"test": "npm run test:server && npm run test:browser", | |||
"start": "http-server", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reckon this script should best be scoped to examples/vanilla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses files from dist
directory. So we need to serve from project root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A relative path can be passed as the first argument to http-server
to determine the location served:
$ http-server ../../
Wooh, thanks! - Just left one comment; rest looks brilliant to me! ✨ |
I realised that it is possible to open the example, as any local html-file with |
Could you remove the |
@yoshuawuyts now we are writing output file using standard Do you know any other solution how to automatically create the |
Gehe, unix tools to the rescue! $ mkdir -p 'dist/' |
Done. Added this as first step of |
This is awesome! One thing as a heads up: 3.0 separates |
@timwis ooh; good call hey |
I've merged the commits into #159 and rebased onto master to resolve the merge conflicts. Heaps thanks! We should land this soonish, ready for |
Good. Anyway I was glad to help you 👍 |