-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved dataset control #327
Merged
chrisiacovella
merged 10 commits into
choderalab:main
from
chrisiacovella:improved_dataset_control
Dec 5, 2024
Merged
Improved dataset control #327
chrisiacovella
merged 10 commits into
choderalab:main
from
chrisiacovella:improved_dataset_control
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the profiler
…omponeents, even if per_system_total_charge is not included.
…overflow on wandb.
MarshallYan
approved these changes
Dec 5, 2024
…ot (meaning we couldn't pass a dictionary to the datamodule; moved up a level to setup_datamodule)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This provides changes aimed at improving the control over datasets. Specifically, the switch to .toml files meant we could not easily toggle which properties to load from the hdf5 files nor which properties to assign to the key internal variables (energy, force, dipole_moment, etc.).
This updates the pydantic dataset model whereby users now additionally define properties of interest (as a list) and then the association of these properties to the internal variable names (i.e used by the
Properties
class). The pydantic model validates that anything in the Properties association also exists in the properties_of_interest list. We do not validate that the properties_of_interest are actually in the hdf5 file via the pydantic model; this is handled when we assign those parameters while calling theDataModule
class. Since this is one of the earliest steps in the process, failure to properly define these should lead to a rapid failure. this saves considerable extra code in the pydantic model, and having to make separate models for each dataset.Key changes
Notable points that this PR has either accomplished or will accomplish.
Associated Issue(s)
Pull Request Checklist