-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Montecarlo barostat #14
Closed
chrisiacovella
wants to merge
14
commits into
choderalab:main
from
chrisiacovella:montecarlo_barostat
Closed
Montecarlo barostat #14
chrisiacovella
wants to merge
14
commits into
choderalab:main
from
chrisiacovella:montecarlo_barostat
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llow same base class to be used for an MC barostat. Also added box_vectors setters/getters in PairsBase class (setter also sets space box_vectors).
…l cost; improved tests of MC barostat.
4 tasks
Closed
Closing this because it's now in redacted code in #21 |
chrisiacovella
requested review from
jchodera
and removed request for
jchodera
February 2, 2024 22:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a simple isotropic MC barostat. This modifies the metroplizedmove base class such that it can handle the barostat move. This has included changing the
_propose_positions
function to take/return box_vectors. Additional changes include storing initial/final box volume if pressure is defined.Note, this will dilate all atoms in the system; for molecular systems we'll need to implement functionality to handle inference of molecules and scaling based on molecule COM.
Edit (24/01/11): After quick discussion of this in the meeting today, I think it is evident we will need to do a major refactor of how we implement the MC move classes after we get these initial ones committed, as the code is definitely starting to get a bit messy. We shouldn't get bogged down with that in this PR, so that we can have these routines to use for other development. I think the overall API used by the MCMCSampler class won't need to change (basically will still just calling
run
regardless of the rest of the code structure) so refactoring should basically be plug and play and not necessarily break things.Todos
Notable points that this PR has either accomplished or will accomplish.
Status