Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Montecarlo barostat #14

Closed

Conversation

chrisiacovella
Copy link
Member

@chrisiacovella chrisiacovella commented Dec 29, 2023

Description

This PR implements a simple isotropic MC barostat. This modifies the metroplizedmove base class such that it can handle the barostat move. This has included changing the _propose_positions function to take/return box_vectors. Additional changes include storing initial/final box volume if pressure is defined.

Note, this will dilate all atoms in the system; for molecular systems we'll need to implement functionality to handle inference of molecules and scaling based on molecule COM.

Edit (24/01/11): After quick discussion of this in the meeting today, I think it is evident we will need to do a major refactor of how we implement the MC move classes after we get these initial ones committed, as the code is definitely starting to get a bit messy. We shouldn't get bogged down with that in this PR, so that we can have these routines to use for other development. I think the overall API used by the MCMCSampler class won't need to change (basically will still just calling run regardless of the rest of the code structure) so refactoring should basically be plug and play and not necessarily break things.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • MC barostat example
  • MC barostat tests
  • Commit ideal gas test system.

Status

  • Ready to go

…llow same base class to be used for an MC barostat. Also added box_vectors setters/getters in PairsBase class (setter also sets space box_vectors).
@chrisiacovella chrisiacovella added enhancement New feature or request WIP labels Dec 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

Merging #14 (128b513) into main (58db5df) will increase coverage by 0.96%.
The diff coverage is 90.22%.

Additional details and impacted files

@chrisiacovella chrisiacovella requested a review from wiederm January 9, 2024 16:14
@chrisiacovella chrisiacovella mentioned this pull request Jan 9, 2024
3 tasks
@chrisiacovella
Copy link
Member Author

Closing this because it's now in redacted code in #21

@chrisiacovella chrisiacovella requested review from jchodera and removed request for jchodera February 2, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants