This repository has been archived by the owner on Oct 11, 2021. It is now read-only.
(GH-143) Ensure checksum is used #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,6 +83,10 @@ | |||
| <Reference Include="System.ComponentModel.DataAnnotations" /> | |||
| <Reference Include="System.Configuration" /> | |||
| <Reference Include="System.Core" /> | |||
| <Reference Include="System.Management.Automation, Version=3.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL"> | |||
There was a problem hiding this comment.
Remove v3 here. You will need to manually edit this file. Look at how Choco does it and follow suit.
There was a problem hiding this comment.
@ferventcoder out of curiousity, what is the reason for doing this?
There was a problem hiding this comment.
Typically it allows any version of SMA to work. So if the system is on v2 or v5, it will still bind.
|
It's a good start - now test with package splatting |
Will do 👍 |
| if (methodsThatRequireChecksums.Any()) | ||
| { | ||
| // find all variables and parameters, and check to see if any of them are named checksum | ||
| var variables = tokens.Where(p => p.Type == PSTokenType.Variable && p.Content.to_lower() == "checksum"); |
There was a problem hiding this comment.
Now define a test where I set the variable checksum, but I don't pass it to the function. And one where I define an empty value and pass it to the function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ferventcoder thoughts?